London | 26-ITP-Jan | Miriam Jorna | Sprint 3 | Todo-list#1206
Open
miriamjorna wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
London | 26-ITP-Jan | Miriam Jorna | Sprint 3 | Todo-list#1206miriamjorna wants to merge 1 commit intoCodeYourFuture:mainfrom
miriamjorna wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
miriamjorna
added
📅 Sprint 3
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Author
|
Closing PR as somehow this is received as the ReadingList branch with the ToDoList files in it. |
This comment has been minimized.
This comment has been minimized.
miriamjorna
changed the title
miriamjorna
added
Needs Review
Luro91
added
the
Review in progress
Luro91
reviewed
Apr 23, 2026
| <ul id="todo-list" class="todo-list"> | ||
| </ul> | ||
| <ul id="todo-list" class="todo-list"> | ||
| <button id="delete-completed-btn">Delete completed tasks</button> |
There was a problem hiding this comment.
I don't see the button when I run the project via the server (npm run serve)
Author
There was a problem hiding this comment.
Ah... no wonder when I've accidentally hidden it in a list... Thanks for spotting that! Sorted now.
There was a problem hiding this comment.
I still don't see it and I don't see any new commits. Did you commit and push your changes?
Luro91
added
Reviewed
miriamjorna
added
the
Needs Review
Luro91
added
Review in progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
To do list made as per instructions, i.e. added functionality to delete all items in one go. Looking forward to coming back to this after the ITP deadline when having time to play with it
ETA: Had lengthy issues making a PR as the GitHub bot stated this needed to be housed under ^Sprint-3/reading-list/ . After several hours of Terminal Tango it turns out the issue could be resolved by just a tiny name change in the title of the PR. Mh. Not at all what the bot said it needed.