Skip to content

London | 26-ITP-Jan | Kris Oldrini | Sprint 3 | Alarm Clock App #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
XiaoQuark wants to merge 7 commits into
base: main
Choose a base branch
from
Open

London | 26-ITP-Jan | Kris Oldrini | Sprint 3 | Alarm Clock App #1208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f67e8d2
coursework: create setAlarm function to change the timeRemaining elem…
XiaoQuark Apr 20, 2026
9fcfad2
set interval based on time input before calling playAlarm
XiaoQuark Apr 20, 2026
ad4a3a6
refactor: delay playAlarm with setTimeout and use setInterval to chan…
XiaoQuark Apr 20, 2026
5932f54
refactor setInterval and remove setTimeout. Inplement clearInterval b…
XiaoQuark Apr 20, 2026
c4c9260
implement change of background colour when alarm plays
XiaoQuark Apr 20, 2026
7a7eb43
refactor: remove unused variables and fix playAlarm timing
XiaoQuark Apr 20, 2026
0f87e64
fix: validate input numbers to be positive integers only and stop tim…
XiaoQuark Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 68 additions & 1 deletion Sprint-3/alarmclock/alarmclock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,70 @@
function setAlarm() {}
const state = {
remainingTime: 0,
timerId: null,
};

function setAlarm() {
if (state.timerId !== null) {
clearInterval(state.timerId);
state.timerId = null;
}

const existingMessage = document.getElementById("error-message");
if (existingMessage) {
existingMessage.remove();
}
const displayedTime = document.getElementById("timeRemaining");
const timeInput = document.getElementById("alarmSet");

state.remainingTime = +timeInput.value;
if (state.remainingTime <= 0 || !Number.isInteger(state.remainingTime)) {
state.remainingTime = 0;
displayedTime.textContent = `Time Remaining: 00:00`;
Copy link
Copy Markdown
Member

@illicitonion illicitonion Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed you have three different places where you set this content to "Time remaining: XX:YY" - imagine you wanted to change this in some way (e.g. "Time Left: XX:YY" or similar) - you'd need to change all three. Can you think how to avoid that?

Copy link
Copy Markdown
Author

@XiaoQuark XiaoQuark Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much Daniel.
I will have a look at this as soon as I'm done with all my submissions.

timeInput.value = "";

const container = document.querySelector(".centre");
const errorMessage = document.createElement("p");
errorMessage.id = "error-message";
errorMessage.textContent = "Please enter a positive whole number";
errorMessage.style.color = "red";
container.appendChild(errorMessage);
return;
}
const formattedTime = formatTime(state.remainingTime);
timeInput.value = "";

displayedTime.textContent = `Time Remaining: ${formattedTime}`;

state.timerId = setInterval(timer, 1000);
}

function formatTime(seconds) {
const remainingSeconds = seconds % 60;
const minutes = (seconds - remainingSeconds) / 60;

const formattedSeconds = remainingSeconds.toString().padStart(2, "0");
const formattedMinutes = minutes.toString().padStart(2, "0");

return `${formattedMinutes}:${formattedSeconds}`;
}

function timer() {
const displayedTime = document.getElementById("timeRemaining");

state.remainingTime -= 1;

if (state.remainingTime <= 0) {
state.remainingTime = 0;
displayedTime.textContent = `Time Remaining: 00:00`;
clearInterval(state.timerId);
state.timerId = null;
document.body.style.backgroundColor = "red";
playAlarm();
return;
}
const countingDownTime = formatTime(state.remainingTime);
displayedTime.textContent = `Time Remaining: ${countingDownTime}`;
}

// DO NOT EDIT BELOW HERE

Expand All @@ -19,6 +85,7 @@ function playAlarm() {
}

function pauseAlarm() {
document.body.style.backgroundColor = "white";
audio.pause();
}

Expand Down
4 changes: 2 additions & 2 deletions Sprint-3/alarmclock/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<!DOCTYPE html>
<!doctype html>
<html lang="en">
<head>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="stylesheet" href="style.css" />
<title>Title here</title>
<title>Alarm clock app</title>
</head>
<body>
<div class="centre">
Expand Down
Loading