CYF_Glasgow | Mansoor Munawar | Module-Onboarding | WEEK1 #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… header, main, article and footer. Also added images and links to the website. And wrapped it within a div element.
…the size of the container to 600px. and used header element to center the heading
…round color. Also removed excess code like div from index.html
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
A-O-Emmanuel
added
Review in progress
There was a problem hiding this comment.
This is okay, I would suggest you read through this article on How to write better git commit messages. Also I think you need to improve your html indentation and spacing, you can read through this article How to indent HTML code and why it's important.
A-O-Emmanuel
added
Reviewed
MansoorM11
added
the
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist
[ ✅] I have committed my files one by one, on purpose, and for a reason
[✅ ] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
[✅ ] I have tested my changes
[✅ ] My changes follow the style guide
[✅ ] My changes meet the requirements of this task
Changelist
Briefly explain your PR.
I have added the content of the website within semantic html.
I have created three article within main element and described what is git, why developers use git, and what is git branch.
I used css to style the website to meet the design requirement
Also used dev tools such as lighthouse to make sure the website is 100% accessible.
Questions