Skip to content

ITP-JAN | ALIZIWE_NGOMA | MODULE-ONBOARDING | WEEK1 #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Aliziwe
Copy link

@Aliziwe Aliziwe commented Feb 8, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

Copy link

netlify bot commented Feb 8, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 8484bc7
🔍 Latest deploy log https://app.netlify.com/sites/cyf-onboarding-module/deploys/67a7a487aa842f0008ba4448
😎 Deploy Preview https://deploy-preview-256--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Aliziwe Aliziwe marked this pull request as draft February 17, 2025 21:08
@Aliziwe Aliziwe marked this pull request as ready for review February 17, 2025 21:10
@Aliziwe Aliziwe marked this pull request as draft February 19, 2025 20:17
@Aliziwe Aliziwe marked this pull request as ready for review February 19, 2025 20:20
@Aliziwe Aliziwe marked this pull request as draft February 19, 2025 20:21
@Aliziwe Aliziwe added the Needs Review Participant to add when requesting review label Feb 24, 2025
@Aliziwe Aliziwe marked this pull request as ready for review February 24, 2025 08:40
@A-O-Emmanuel A-O-Emmanuel added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is okay, good job!

Copy link

@A-O-Emmanuel A-O-Emmanuel Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should take another look at the wireframe, the page title and description should be centered and the footer also needs to be centered. you also need to work on your indentation and spacing please look at this article: How to indent your HTML code and why it's important

@A-O-Emmanuel A-O-Emmanuel added Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 26, 2025
@OracPrime OracPrime removed the Needs Review Participant to add when requesting review label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants