ITP-Jan-25 Cape Town | Jordy Mukandayi | Module-Onboarding | Form-Controls |Week2 #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| <label for="name">Name</label> | ||
| <input | ||
| type="text" | ||
| name="name" |
There was a problem hiding this comment.
You need to require a min of 2 char for the name
There was a problem hiding this comment.
I added minlength="2" for require 2 char
| <input | ||
| type="text" | ||
| name="email" | ||
| id="email" |
There was a problem hiding this comment.
You need to ensure that the email is valid
There was a problem hiding this comment.
I changed type="text" to type="email"
| <option value="XXL">XXL</option> | ||
| </select> | ||
| </div> | ||
| <div class="radio"> |
There was a problem hiding this comment.
the select size have the required
Form-Controls/styles.css
Outdated
| @@ -0,0 +1,123 @@ | |||
| body { | |||
Waldo-Strydom
added
👀 Review Requirements
3 tasks
| @@ -0,0 +1,124 @@ | |||
| /* body { */ | |||
| <label for="name">Name</label> | ||
| <input | ||
| type="text" | ||
| name="name" |
| <input | ||
| type="text" | ||
| name="email" | ||
| id="email" |
| <option value="XXL">XXL</option> | ||
| </select> | ||
| </div> | ||
| <div class="radio"> |
| </div> | ||
| <div class="radio"> | ||
| <div> | ||
| <label for="black">Black</label> |
There was a problem hiding this comment.
The colors also needs to be required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.