Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

London ITP January | Khalil Ali | Module-Onboarding | Week1 #261

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

London ITP January | Khalil Ali | Module-Onboarding | Week1 #261

wants to merge 5 commits into from

Conversation

khalil-ali1
Copy link

@khalil-ali1 khalil-ali1 commented Feb 11, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@netlify Netlify
Copy link

netlify bot commented Feb 11, 2025 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 152dd52
🔍 Latest deploy log https://app.netlify.com/sites/cyf-onboarding-module/deploys/67ab2c05ace7c60008afd6d3
😎 Deploy Preview https://deploy-preview-261--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 97 (🔴 down 3 from production)
Best Practices: 96 (🔴 down 4 from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@khalil-ali1 khalil-ali1 mentioned this pull request Feb 11, 2025
Open
@A-O-Emmanuel A-O-Emmanuel added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 15, 2025
A-O-Emmanuel
A-O-Emmanuel reviewed Feb 15, 2025
View reviewed changes
Wireframe/index.html
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, good work!

A-O-Emmanuel
A-O-Emmanuel reviewed Feb 15, 2025
View reviewed changes
Wireframe/style.css
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also good.

@A-O-Emmanuel A-O-Emmanuel added Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@A-O-Emmanuel A-O-Emmanuel A-O-Emmanuel left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Reviewed Volunteer to add when completing a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khalil-ali1 @A-O-Emmanuel