London ITP January 25 | Khalil Ali | Module-Onboarding | Week2 #262
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
day-lee
added
the
Review in progress
|
Thank you for the submission. For your work to be reviewed, it is important to change labels as 'Needs review'. This will ensure that your work appears on PR tracking dashboard for volunteers so we can review it in a timely manner. Please add the label as 'Needs review'. |
Form-Controls/index.html
Outdated
| type="text" | ||
| id="name" | ||
| name="name" | ||
| minlength="2" |
There was a problem hiding this comment.
It seems the name input accepts numbers as well. Can you think of a pattern attribute that only accepts a text string of two characters or more?
FYI, Requirement: I require a valid name. I have defined a valid name as a text string of two characters or more.
There was a problem hiding this comment.
Many Thanks for you on your time and effort.
pattern="^[a-zA-Z\s\-']{2,}$"
this pattern would do the task.
pattern="^[a-zA-Z\s-']{2,}$"This is a regular expression that checks for a minimum of two letters, and allows for spaces, hyphens, and apostrophes
Form-Controls/index.html
Outdated
| </select> | ||
| </fieldset> | ||
| <br /> | ||
| <input type="button" value="Submit" /> |
There was a problem hiding this comment.
While the requirement states, "Do not write a form action for this project," it is important to test the functionality. With input type="button", the form won't submit at all, and therefore it won't validate the form either. Can you think of another type attribute that would allow you to test the form?
day-lee
added
Reviewed
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.