London_cohort| Aung Ye Kyaw | Module-Onboarding | Week1|Formcontrol

[sarawone]

Form control exercise

1. I have used HTML only.
2. I have not used any CSS or JavaScript.
3. My form is semantic html.
4. All inputs have associated labels.
5. My Lighthouse Accessibility score is 100.
6. I require a valid name. I have defined a valid name as a text string of two characters or more.
7. I require a valid email.
8. I require one colour from a defined set of 3 colours.
9. I require one size from a defined set of 6 sizes.

[netlify]

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	6a62a19
🔍 Latest deploy log	https://app.netlify.com/sites/cyf-onboarding-module/deploys/67ad3a97393a690008fff15d
😎 Deploy Preview	https://deploy-preview-263--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 100 (no change from production) Accessibility: 93 (🔴 down 7 from production) Best Practices: 100 (no change from production) SEO: 90 (🟢 up 4 from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[day-lee]

Good job! Your code is easy to read and looks good overall.

I have a few suggestions:

1. When I type one character for the name input, it still accepts the value. The current regex pattern requires one or more ("+") characters. Consider a way to ensure a valid name is a text string of two characters or more. You could use a regex pattern or set a minimum length attribute.

2. The name, email, and size fields are wrapped with p tags. While the p tag is used for grouping content, it is typically intended for blocks of text. Can you change the code to make it semantically more appropriate?

3. The current accessibility score is 93. I see there is room for improvement. Can you change the code so it can achieve a score of 100?

Keep up the good work!