London-ITP-Jan| Rawan_Almutairi| FormControl| week2 #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
A-O-Emmanuel
added
the
Review in progress
| <span>T-Shirt Color:</span> | ||
|
|
||
| </label> | ||
| <select id="t-shirt-color" name="t-shirt-color"> <!-- giving the user choices to choose from using the select tag --> |
There was a problem hiding this comment.
One color from a defined set of three is supposed to be required. Please look at the task description for clarification
| <span>T-Shirt Size:</span> | ||
|
|
||
| </label> | ||
| <select id="t-shirt-size" name="t-shirt-size"> |
There was a problem hiding this comment.
Also one size from a defined set of 6 sizes is supposed to be required. Please look at the task description again to understand what to do. Good Job!
There was a problem hiding this comment.
This is okay, good job, however, the footer is supposed to be fixed to the bottom of the view port, please look at the task description to understand what to do. Good work!
A-O-Emmanuel
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.