Skip to content

ZA | May-2025 | Fikiswa Matoti | Wireframe #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

FiksMat
Copy link

@FiksMat FiksMat commented Jun 3, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

This pull request submits the assignment titled Wireframe to Web Code. It includes summaries explaining the purpose of a wireframe, the role of a README file, and an overview of a branch in Git.

Questions

Ask any questions you have for your reviewer.

Copy link

netlify bot commented Jun 3, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 14399e1
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/683f0d384777a90008a35083
😎 Deploy Preview https://deploy-preview-685--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@FiksMat FiksMat added the Needs Review Participant to add when requesting review label Jun 3, 2025
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation is solid. PR description is well prepared.

According to https://validator.w3.org/, there is an error in your code. Can you fix it?

Comment on lines 39 to 41
<a href="https://careerfoundry.com/en/blog/ux-design/what-is-a-wireframe-guide/#what-is-the-purpose-of-wireframing" target="_blank">Read more</a>
</article>
<article>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use VSCode's "Format Document" feature to keep the code indented?
To use the feature, right-click inside the code editor and select the option.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have resolved the issue with spaces and brackets in the image file name and have also updated the indentation throughout the code.

Thank you for the suggestion about VS Code's Format Document feature. I will incorporate it into my future coding assignments.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jun 3, 2025
@FiksMat FiksMat added Needs Review Participant to add when requesting review and removed Reviewed Volunteer to add when completing a review labels Jun 3, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Jun 3, 2025

Changes look good! Nicely done!

@cjyuan cjyuan added Complete Volunteer to add when work is complete and review comments have been addressed and removed Needs Review Participant to add when requesting review labels Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Volunteer to add when work is complete and review comments have been addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants