-
-
Notifications
You must be signed in to change notification settings - Fork 266
ZA | May-2025 | Fikiswa Matoti | Wireframe #685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation is solid. PR description is well prepared.
According to https://validator.w3.org/, there is an error in your code. Can you fix it?
Wireframe/index.html
Outdated
<a href="https://careerfoundry.com/en/blog/ux-design/what-is-a-wireframe-guide/#what-is-the-purpose-of-wireframing" target="_blank">Read more</a> | ||
</article> | ||
<article> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use VSCode's "Format Document" feature to keep the code indented?
To use the feature, right-click inside the code editor and select the option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have resolved the issue with spaces and brackets in the image file name and have also updated the indentation throughout the code.
Thank you for the suggestion about VS Code's Format Document feature. I will incorporate it into my future coding assignments.
Changes look good! Nicely done! |
Learners, PR Template
Self checklist
Changelist
This pull request submits the assignment titled Wireframe to Web Code. It includes summaries explaining the purpose of a wireframe, the role of a README file, and an overview of a branch in Git.
Questions
Ask any questions you have for your reviewer.