Skip to content

London | May-2025 | Birhan Mesfen | Wireframe #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Birhan-lab
Copy link

@Birhan-lab Birhan-lab commented Jun 3, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Copy link

netlify bot commented Jun 3, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 6cc9c26
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/683f4c37fbc2310008de929d
😎 Deploy Preview https://deploy-preview-686--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 98 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (🔴 down 4 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@Birhan-lab Birhan-lab added the Needs Review Participant to add when requesting review label Jun 3, 2025
@eediallo eediallo added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jun 3, 2025
Comment on lines 1 to 8
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Wireframe</title>
<title>Web Devlopment Bascis</title>
<link rel="stylesheet" href="style.css" />
</head>
<body>
Copy link

@eediallo eediallo Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great so far. However, it is missing the DOCTYPE and the html tags. Could you please add them?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have update it can you check it please?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you

@eediallo eediallo added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jun 3, 2025
@eediallo eediallo added Complete Volunteer to add when work is complete and review comments have been addressed and removed Reviewed Volunteer to add when completing a review labels Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Volunteer to add when work is complete and review comments have been addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants