-
-
Notifications
You must be signed in to change notification settings - Fork 264
London| May 2025| Payam Ghanbari | Wireframe Updated #690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…es and alignments.
…ld be fine in a state that meets all the requiremetns.
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
According to https://validator.w3.org/, there is an error in your code. Can you fix them?
-
When a wireframe is provided, our implementation should closely reflect its appearance and layout to ensure consistency with design expectations. You're off to a solid start. To better align with the wireframe, can you make the images as wide as the articles? The main purpose of implementing a wireframe is to translate structure and functionality, not final visual design. Visual design is usually handled by UI/graphic designers after the wireframe phase. You can also set all images to
placeholder.svg
. -
Can you format the checked boxes using the proper Markdown syntax in your PR description so that they look something like this?
(With proper Markdown syntax, we can use mouse to check/uncheck the items)
Changed the width of the images to the size of the article as requested.
Learners, PR Template
Self checklist
Changelist
Questions
Ask any questions you have for your reviewer.