Skip to content

London| May 2025| Payam Ghanbari | Wireframe Updated #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

payam1904
Copy link

@payam1904 payam1904 commented Jun 4, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

  • Fixed the issues with the css
  • added images and replaced the paragraphs with relevant information.
  • links added to the resources for reference
  • the title has changed and the footer is modified and positioned as required.

Questions

Ask any questions you have for your reviewer.

Copy link

netlify bot commented Jun 4, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 997d5f3
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6841a82d32a8ec0008d7619a
😎 Deploy Preview https://deploy-preview-690--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@payam1904 payam1904 requested a review from jenny-alexander June 4, 2025 09:40
@payam1904 payam1904 added the Needs Review Participant to add when requesting review label Jun 4, 2025
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. According to https://validator.w3.org/, there is an error in your code. Can you fix them?

  2. When a wireframe is provided, our implementation should closely reflect its appearance and layout to ensure consistency with design expectations. You're off to a solid start. To better align with the wireframe, can you make the images as wide as the articles? The main purpose of implementing a wireframe is to translate structure and functionality, not final visual design. Visual design is usually handled by UI/graphic designers after the wireframe phase. You can also set all images to placeholder.svg.

  3. Can you format the checked boxes using the proper Markdown syntax in your PR description so that they look something like this?
    image
    (With proper Markdown syntax, we can use mouse to check/uncheck the items)

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jun 5, 2025
Changed the width of the images to the size of the article as requested.
@payam1904 payam1904 added Needs Review Participant to add when requesting review and removed Reviewed Volunteer to add when completing a review labels Jun 5, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Jun 5, 2025

You fixed the errors, the image width, and you removed most of the inline CSS. Well done.
(There is a an inline CSS left in the HTML)

The 3rd comment in my in my previous feedback refers to these checkboxes, can you fix them?
image

I will mark this PR as "Complete" first.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and review comments have been addressed and removed Needs Review Participant to add when requesting review labels Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Volunteer to add when work is complete and review comments have been addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants