London | May-2025| Hadi Vahidi | Form-controls #698
Conversation
in this version I just edited the index of Form control whit out changing other files
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Form implementation is very solid and code is error free. Nicely done!
-
Why deleted everything in the PR template when preparing the PR description? Can you restore the PR template, then
- Check the items in the Self-Checklist to confirm your pull request meets the guidelines (which you have done! Good!)
- Provide a brief description (under the "Changelist" section) summarizing the purpose of the PR and the changes you’ve made
-
Can you also address the inline comments I left with the code?
| <style> | ||
| .form-group { | ||
| margin-bottom: 15px; | ||
| } | ||
| .radio-option { | ||
| display: flex; | ||
| align-items: center; | ||
| padding: 10px 0; | ||
| } | ||
| .radio-option input[type="radio"] { | ||
| width: 20px; | ||
| height: 20px; | ||
| margin-right: 8px; | ||
| } | ||
| select { | ||
| padding: 8px; | ||
| font-size: 16px; | ||
| } | ||
| button { | ||
| padding: 12px 24px; | ||
| font-size: 16px; | ||
| } | ||
| </style> |
There was a problem hiding this comment.
Spec says "No CSS", can you remove them?
You can use the line break element to create vertical space between input elements.
|
|
||
| <div class="form-group"> | ||
| <label for="name">Full Name (min 2 characters):</label> | ||
| <input type="text" id="name" name="name" required minlength="2"> |
There was a problem hiding this comment.
Currently a user can enter a name consisting of only space characters (e.g., " "). Can you enforce a stricter validation rule using the pattern attribute to disallow any name that contains only space characters?
cjyuan
added
Reviewed
in this version I just edited the index of Form control whit out changing other files
now the code is completely passed the W3 vlaidating and lighthouse.