Skip to content

GLASGOW | ITP_MAY-25 | VALENTYN_PRONCHENKO | FORM_CONTROLS #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

valentpron
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

Copy link

netlify bot commented Jun 5, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 861df34
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6841c45d8a4b33000816c438
😎 Deploy Preview https://deploy-preview-703--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 83 (🔴 down 3 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@valentpron valentpron self-assigned this Jun 5, 2025
@valentpron valentpron added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Participant to add when requesting review Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jun 5, 2025
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Form implementation is quite solid. Code is well indented.

  1. According to https://validator.w3.org/, there is no errors but there are some warnings in your code. Can you fix the warnings?

  2. Can you improve the Lighthouse Accessibility score to 100?

  3. To follow best practices, in your PR description, can you provide a brief description (under the "Changelist" section) summarizing the purpose of the PR and the changes you’ve made?
    image

Comment on lines +63 to +72
<label for="size">Size:</label>
<select id="size" name="size" multiple required>
<option value="" disabled selected>Select size</option>
<option value="S">Extra Small (XS)</option>
<option value="S">Small (S)</option>
<option value="M">Medium (M)</option>
<option value="L">Large (L)</option>
<option value="XL">Extra Large (XL)</option>
<option value="XXL">Double Extra Large (XXL)</option>
</select>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this input elements, a user can select any number of sizes. It does not quite satisfy the requirement "I require one size from a defined set of 6 sizes."

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed Volunteer to add when completing a review 📅 Sprint 1 Assigned during Sprint 1 of this module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants