GLASGOW | ITP_MAY-25 | VALENTYN_PRONCHENKO | FORM_CONTROLS #703
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
valentpron
added
📅 Sprint 1
There was a problem hiding this comment.
Form implementation is quite solid. Code is well indented.
-
According to https://validator.w3.org/, there is no errors but there are some warnings in your code. Can you fix the warnings?
-
Can you improve the Lighthouse Accessibility score to 100?
-
To follow best practices, in your PR description, can you provide a brief description (under the "Changelist" section) summarizing the purpose of the PR and the changes you’ve made?
| <label for="size">Size:</label> | ||
| <select id="size" name="size" multiple required> | ||
| <option value="" disabled selected>Select size</option> | ||
| <option value="S">Extra Small (XS)</option> | ||
| <option value="S">Small (S)</option> | ||
| <option value="M">Medium (M)</option> | ||
| <option value="L">Large (L)</option> | ||
| <option value="XL">Extra Large (XL)</option> | ||
| <option value="XXL">Double Extra Large (XXL)</option> | ||
| </select> |
There was a problem hiding this comment.
With this input elements, a user can select any number of sizes. It does not quite satisfy the requirement "I require one size from a defined set of 6 sizes."
cjyuan
added
Reviewed
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.