Sheffield | 3 May-2025 | Xiayidan Abuduxukuer | Form Controls

[Shayida999]

Learners, PR Template

Self checklist,

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

• Created a semantic HTML form for t-shirt orders.
• Includes required fields: name (min 2 characters), email (valid format), colour (3 radio options), size (6 select options).
• All form inputs have proper labels.
• No CSS or JavaScript used, per task requirements.

Questions

None at the moment — ready for review!

[netlify]

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	aa35b5f
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/68433900581623000857cadc
😎 Deploy Preview	https://deploy-preview-705--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 98 (🔴 down 2 from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[cjyuan]

Code is error-free and well-indented. Form implementation is solid and PR description is nicely prepared. Excellent!

A PR branch should include only the changes relevant to the specific task or feature it addresses. This branch, created for the "Form-Controls" exercise, currently contains some unrelated changes (see pic)

Note: I assume these four files are not part of your form implementation.

Can you carry out the following steps to make this branch clean?

1. In form-controls-completed branch, delete the sub-folder wireframe-task.
2. In form-controls-completed branch, replace both index.html and style.css in the "Wireframe" folder by the version of the files in the main branch. You can download them from here:
   https://github.com/Shayida999/Module-Onboarding/tree/main/Wireframe
3. Commit the change (there should be 4 affected files)
4. Push your commit to Github.

[cjyuan]

Currently a user can enter a name consisting of only space characters (e.g., " "). Can you enforce a stricter validation rule using the pattern attribute to disallow any name that contains only space characters?

[Shayida999]

Hi CJ.

I have now:

Removed the wireframe-task folder
Restored the correct Wireframe files from main
Added a pattern to the name input to block whitespace-only names

Is everything ok now?? Thank you

[cjyuan]

Changes look good! Well done!

[Shayida999]

@cjyuan

I’m really glad everything looks good now — thank you so much!

I just wanted to let you know: while I was checking your feedback, my baby accidentally pressed some keys on my laptop 😅 and I think something may have been deleted in the “Labels” section on GitHub. So sorry about that TvT.

and i have one more question ,just to confirm, is the final step now to complete the Duolingo test? Should I aim to finish it today?

[cjyuan]

I responded your question about Duolingo test on Slack.