CapeTown | May-2025 | Wahae Koela | Wireframe

[blackoutisback]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

extra section tag removed
made sure correct article order
fixed the W3C issue
prevented the footer overlapping

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

[netlify]

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	77495ab
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/68434f44b557260008287ec4
😎 Deploy Preview	https://deploy-preview-710--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 91 (🟢 up 5 from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[cjyuan]

1. When a wireframe is provided, our implementation should closely reflect its appearance and layout to ensure consistency with design expectations. You're off to a solid start. To better align with the wireframe, can you layout the articles so that
   • The 1st article is on top of the 2nd and 3rd articles
   • The left edge of the 1st article is aligned with the left edge of the 2nd article
   • The right edge of the 1st article is aligned with the right edge of the 3rd article

For example,

2. According to https://validator.w3.org/, there is a warning in your code. Can you fix it?

3. When the page is fully scrolled to the bottom, the "Read more" link of the bottom article is partially blocked by the footer. Can you address this issue?
   

4. To follow best practices, in your PR description, can you provide a brief description (under the "Changelist" section) summarizing the purpose of the PR and the changes you’ve made?
   

[cjyuan]

Changes look good. Well done!

Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:

• Reply to their feedback.
  • In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
  • Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
• Replace the "Reviewed" label by a "Needs review" label (which you have done -- great!)
  • Without this label, the reviewer would not know if your changes is ready to be reviewed.

Also, can you find out from ChatGPT the following

• What's the best practice to respond to reviewer reviews in a PR?
• How to respond to comments in a conversation in a PR?

and practice what you find in future PRs?