CapeTown | May-2025 | Wahae Koela | Form Control #711
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Why did you close this PR? |
There was a problem hiding this comment.
Not sure if this PR was closed by accident.
Should this PR be reopened, here is my feedback:
Form implementation is pretty solid.
-
According to https://validator.w3.org/, there is an error in your code. Can you fix it?
-
Can you improve the Lighthouse Accessibility score of your page to 100?
-
To follow best practices, in your PR description, can you provide a brief description (under the "Changelist" section) summarizing the purpose of the PR and the changes you’ve made?
Form-Controls/index.html
Outdated
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| <label for="name">Name:</label> | ||
| <input type="text" id="name" name="name" required /> |
There was a problem hiding this comment.
Currently a user can enter a name consisting of only space characters (e.g., " "). Can you enforce a stricter validation rule using the pattern attribute to disallow any name that contains only space characters?
There was a problem hiding this comment.
was a mistake editing all things now
cjyuan
added
Reviewed
blackoutisback
added
Needs Review
|
Changes look good. I just noticed the Lighthouse Accessibility score of your page is not yet 100. I am sure you can improve them to 100 easily. Now that you have completed both your PRs, please follow the instructions in #570 to prepare what you need to submit on the Course Platform. |
cjyuan
added
Complete
Learners, PR Template
Self checklist
Changelist
removed the redundant
added pattern to the name
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.