generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 349
London | 25-ITP-May | GISLAINE DELLA BELLA | Sprint 2 | FORM STRUCTURE #835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Della-Bella
wants to merge
27
commits into
CodeYourFuture:main
Choose a base branch
from
Della-Bella:FormStructure
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
dfab5a1
Add Articles elemnts
Della-Bella 95d68b0
Article content
Della-Bella b9840db
footer content
Della-Bella 37e3a22
add content and footer info
Della-Bella 9193e31
menu
Della-Bella fa43c3e
menu
Della-Bella dae4510
first css
Della-Bella eca4b8e
fisrt styles
Della-Bella 2be249e
playing with CSS
Della-Bella 2ffda09
fix CSS
Della-Bella 16f2c2e
Accessibility Fixes
Della-Bella f450f44
Form basic structure
Della-Bella 02a38c3
Acessibly form
Della-Bella 028d781
final code
Della-Bella 041d37e
test pr
Della-Bella 2a1e517
test 2
Della-Bella eb77113
fix error - deleted folder
Della-Bella b1a61a6
Accessibility Check
Della-Bella 790a166
Accessibility check
Della-Bella 900013f
Accessibility Check
Della-Bella 36feda1
Accessibility check
Della-Bella 792f427
Accessibility check 2
Della-Bella e8fbafc
Fixed final errors
Della-Bella e064761
Removed README.md as per PR instructions
Della-Bella ff054ba
Cleaned up PR: Removed all files and folders not belongs Structure br…
Della-Bella 48ce7b5
test recover
Della-Bella ce6a98e
Merge remote-tracking branch 'refs/remotes/origin/FormStructure' into…
Della-Bella File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,115 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | ||
| <title>My form exercise</title> | ||
| <meta name="description" content="" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| </head> | ||
| <body> | ||
| <header> | ||
| <h1>Product Pick</h1> | ||
| </header> | ||
| <main> | ||
| <form> | ||
| <!-- write your html here--> | ||
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| </form> | ||
| </main> | ||
| <footer> | ||
| <!-- change to your name--> | ||
| <h2>By HOMEWORK SOLUTION</h2> | ||
| </footer> | ||
| </body> | ||
| </html> | ||
|
|
||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | ||
| <title>My form exercise</title> | ||
| <meta name="description" content="" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| </head> | ||
|
|
||
| <body> | ||
| <header> | ||
| <h1>Product </h1> | ||
| </header> | ||
| <main> | ||
| <!-- Write a valid form / Test with Devtools/Refactor using Devtools --> | ||
|
|
||
| <form> | ||
| <!-- customer's name/ require--> | ||
| <fieldset> | ||
| <legend> | ||
| <h2> Pick Your T-shirt</h2> | ||
| </legend> | ||
| <p> | ||
| Required fields are followed by | ||
| <strong><span aria-label="required">*</span></strong> | ||
| </p> | ||
|
|
||
| <p> | ||
| <label for="name"><strong>Name *</strong></label> | ||
| </p> | ||
| <input type="text" id="name" name="user_name" required minlength="2" /> | ||
|
|
||
| <!-- customer's e-amil/ require--> | ||
|
|
||
| <p><label for="e-mail"><span><strong>E-mail *</strong></span></label> | ||
| </p> | ||
| <input type="email" id="e-mail" name="user_email" required /> | ||
|
|
||
| <!-- 3 options colour/ pick only 1/ require --> | ||
|
|
||
| <label for="colour-yellow"> | ||
| <p><strong>Colour:</strong></p> | ||
| <input type="radio" style="transform: scale(2)" id="colour-yellow" value="yellow" name="colour" required /> | ||
| <span>Yellow </span> | ||
| </label> | ||
|
|
||
| <label for="colour-red"> | ||
| <input type="radio" style="transform: scale(2)" id="colour-red" value="red" name="colour" required /> | ||
| <span>Red </span> | ||
| </label> | ||
|
|
||
| <label for="colour-blue"> | ||
| <input type="radio" style="transform: scale(2)" id="colour-blue" value="blue" name="colour" required /> | ||
| <span>Blue </span> | ||
| </label> | ||
|
|
||
| <!--6 options: XS, S, M, L, XL, XXL/ pick only 1 / require--> | ||
| <p><strong>Size:</strong></p> | ||
| <ul> | ||
|
|
||
| <li> | ||
| <label for="size-xs"> | ||
| <input type="radio" style="transform: scale(1.5); margin-bottom: 20px;" id="size-xs" name="size" | ||
| value="size-xs" required><span> XS </span> | ||
| </label> | ||
| </li> | ||
|
|
||
| <li> | ||
| <label for="size-s"> | ||
| <input type="radio" style="transform: scale(1.5) ; margin-bottom: 20px"; id="size-s" name="size" value="size-s" | ||
| required><span> S </span> | ||
| </label> | ||
| </li> | ||
|
|
||
| <li> | ||
| <label for="size-m"> | ||
| <input type="radio" style="transform: scale(1.5); margin-bottom: 20px"; id="size-m" name="size" value="size-m" | ||
| required><span> M </span> | ||
| </label> | ||
| </li> | ||
|
|
||
| <li> | ||
| <label for="size-l"> | ||
| <input type="radio" style="transform: scale(1.5); margin-bottom: 20px"; id="size-l" name="size" value="size-l" | ||
| required><span> L </span> | ||
| </label> | ||
| </li> | ||
|
|
||
| <li> | ||
| <label for="size-xl"> | ||
| <input type="radio" style="transform: scale(1.5); margin-bottom: 20px"; id="size-xl" name="size" value="size-xl" | ||
| required><span> XL </span> | ||
| </label> | ||
| </li> | ||
|
|
||
| <li> | ||
| <label for="size-xxl"> | ||
| <input type="radio" style="transform: scale(1.5); margin-bottom: 20px"; id="size-xxl" name="size" value="size-xxl" | ||
| required><span> XXL</span> | ||
| </label> | ||
| </li> | ||
| </ul> | ||
| <button type="submit">Add To Cart </button> | ||
| </fieldset> | ||
| </form> | ||
| </main> | ||
| <footer> | ||
| <!-- change to your name--> | ||
| <h3>By Gisline Della Bella</h3> | ||
| </footer> | ||
| </body> | ||
|
|
||
| </html> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you review all of the radio button values? They have
value ="color-*"instead of the size value (for example,value="BLUE").