-
-
Notifications
You must be signed in to change notification settings - Fork 340
WEST MIDLANDS | ITP-September-2025 | MUSTAF ASANI | Sprint 1 | Wireframe #888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…h in first article
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
LonMcGregor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start on this sprint's tasks, I have spotted an area where you could improve code further
| <h2>Title</h2> | ||
| <img | ||
| src="https://media.geeksforgeeks.org/wp-content/uploads/20240702120959/Readme1.png" | ||
| alt="" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can leave the "alt" attribtute blank if the image is purely decorative. I think that is the case here, so you don't need to change it, but just keep that in mind.
| <footer> | ||
| <p> | ||
| This is the default, provided code and no changes have been made yet. | ||
| This page was created as a simple example of a wireframe and to explain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At times the footer text overlaps with the page content which is difficult to read - can you think of how to fix this while keeping the footer at the bottom of the viewport?
|
This looks good to me - congratulations! |


Learners, PR Template
Self checklist
Changelist
Added three articles with images and changed some of the text in the header and the p tag in the header.