Skip to content

Conversation

@asaniDev
Copy link

@asaniDev asaniDev commented Oct 4, 2025

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Added three articles with images and changed some of the text in the header and the p tag in the header.

@netlify
Copy link

netlify bot commented Oct 4, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit a147383
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/68e7c408af4cd4000840360e
😎 Deploy Preview https://deploy-preview-888--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Oct 4, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@asaniDev asaniDev added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 4, 2025
@github-actions
Copy link

github-actions bot commented Oct 4, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@asaniDev asaniDev changed the title WEST MIDLANDS | September-2025 | MUSTAF ASANI | Wireframe WEST MIDLANDS | ITP-September-2025 | MUSTAF ASANI | Sprint 1 | Wireframe Oct 4, 2025
@github-actions
Copy link

github-actions bot commented Oct 4, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start on this sprint's tasks, I have spotted an area where you could improve code further

<h2>Title</h2>
<img
src="https://media.geeksforgeeks.org/wp-content/uploads/20240702120959/Readme1.png"
alt=""

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can leave the "alt" attribtute blank if the image is purely decorative. I think that is the case here, so you don't need to change it, but just keep that in mind.

<footer>
<p>
This is the default, provided code and no changes have been made yet.
This page was created as a simple example of a wireframe and to explain

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At times the footer text overlaps with the page content which is difficult to read - can you think of how to fix this while keeping the footer at the bottom of the viewport?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 6, 2025
@asaniDev asaniDev added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 8, 2025
@LonMcGregor
Copy link

Now the footer is sticking to the bottom of the page. It was already fixed to the bottom of the viewport. (Do you know the difference between viewport and page?)

In my earlier comment I was actually asking about the fact that sometimes the text of the footer overlaps the text of the page making it difficult to read. It should be possible to resolve that with a simple fix without changing the layout.

Can you put back the positioning you had, but try to fix the readability issue?

image

@LonMcGregor LonMcGregor removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 8, 2025
@asaniDev asaniDev added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 9, 2025
@illicitonion illicitonion added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 10, 2025
@illicitonion
Copy link
Member

This looks good to me - congratulations!

@illicitonion illicitonion self-requested a review October 10, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants