Skip to content

Conversation

@sofayas
Copy link

@sofayas sofayas commented Oct 6, 2025

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Created a semantic HTML form for the “Form Controls” project.
Added required fields for full name, email, colour (3 options), and size (6 options).
Added form validation for name (min 2 chars) and email format.
Ensured all inputs have labels and use semantic HTML.
Verified accessibility and HTML validity.

This pull request adds a complete HTML form for the “Form Controls” task.
The form collects a user’s name, email, preferred T-shirt colour, and size using semantic HTML.
All inputs are required and validated to meet accessibility and form validation standards.

@netlify
Copy link

netlify bot commented Oct 6, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit dc22576
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/68e39f8adf5dcd0008e2ebb8
😎 Deploy Preview https://deploy-preview-897--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@sofayas sofayas added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 6, 2025
@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

2 similar comments
@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@CameronDowner CameronDowner added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 6, 2025
@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@CameronDowner
Copy link

This submission is looking great 🙂

You are getting some failed checks though, you need to either:

  • Add a question to your PR description under "Questions"
  • If you don't have any questions, you can remove the "Questions" section entirely
image

Once you've done this, all checks should pass and I will mark as complete

@CameronDowner CameronDowner added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 6, 2025
@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@CameronDowner CameronDowner added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 6, 2025
@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@sofayas sofayas added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed 📅 Sprint 2 Assigned during Sprint 2 of this module labels Oct 7, 2025
@sofayas
Copy link
Author

sofayas commented Oct 7, 2025

This submission is looking great 🙂

You are getting some failed checks though, you need to either:

  • Add a question to your PR description under "Questions"
  • If you don't have any questions, you can remove the "Questions" section entirely
image Once you've done this, all checks should pass and I will mark as complete

Dear Cameron, i have fixed the problem, can you please review my work again.
thanks

@sofayas sofayas changed the title Manchester | ITP-SEP-2025 | Sopyas Solomon | Sprint 2 | Form-Control Manchester | ITP-SEP-2025 | Sofayas Solomon | Sprint 2 | Form-Control Oct 7, 2025
@sofayas sofayas added the 📅 Sprint 2 Assigned during Sprint 2 of this module label Oct 7, 2025
@CameronDowner CameronDowner added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 7, 2025
@CameronDowner
Copy link

Marked as complete 🙂

@sofayas
Copy link
Author

sofayas commented Oct 7, 2025

Marked as complete 🙂

Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants