Manchester | 25-ITP-September | Fatimatou Bah | Sprint 2 | Form Controls #908
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
Faatima-Bah
added
the
Needs Review
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Code looks good. Just some minor change needed.
Form-Controls/index.html
Outdated
| <footer> | ||
| <!-- change to your name--> | ||
| <h2>By HOMEWORK SOLUTION</h2> | ||
| </footer> | ||
| <footer>By Homework solution.</footer> |
There was a problem hiding this comment.
Not yet updated according to the instruction in the comment.
Form-Controls/index.html
Outdated
| <label for="name">Full name:</label> | ||
| <input id="name" name="name" type="text" minlength="2" required aria-describedby="name-help" /> | ||
| <small id="name-help">Name must be at least two characters.</small> | ||
|
|
||
| <label for="email">Email address:</label> | ||
| <input id="email" name="email" type="email" required aria-describedby="email-help" /> | ||
| <small id="email-help">Enter a valid email, e.g. [email protected].</small> |
There was a problem hiding this comment.
Could you make them to appear in two separate rows?
Currently the help message of "Full name" is and the "Email address" label are a bit hard to read.
There was a problem hiding this comment.
Thank you, I have made some improvement, can you review it again. thank you
cjyuan
added
Reviewed
Faatima-Bah
added
Needs Review
cjyuan
added
Complete
|
Changes look good. Well done. Remember to submit your Step 1 on the Course Platform. |
2 participants
Learners, PR Template
Self checklist
Changelist
I have create a valid form using only html.
My form interpret requirements and check against a list of criteria.