Skip to content

Conversation

@chibu0070
Copy link

@chibu0070 chibu0070 commented Oct 10, 2025

This PR adds a semantic HTML form that collects customer information for T-shirt orders.

The form includes fields for name, email, colour, and size, with built-in HTML hoping everyting is completed correctly

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

@netlify
Copy link

netlify bot commented Oct 10, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 64614d8
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/68ea6bd76a87290008af033c
😎 Deploy Preview https://deploy-preview-910--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 85 (🔴 down 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@chibu0070 chibu0070 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Oct 10, 2025
@github-actions
Copy link

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

5 similar comments
@github-actions
Copy link

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@github-actions
Copy link

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@github-actions
Copy link

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@github-actions
Copy link

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@github-actions
Copy link

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@chibu0070 chibu0070 added the 📅 Sprint 2 Assigned during Sprint 2 of this module label Oct 11, 2025
@chibu0070 chibu0070 changed the title Glasgow | 25-ITP-Sep | Chibuikem Okwu | Sprint 2 | Form-Controls Glasgow | 25-ITP-SEP | Chibuikem Okwu | Sprint 2 | Form-Controls Oct 11, 2025
@YoanHlebarov YoanHlebarov added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Oct 11, 2025
Copy link

@YoanHlebarov YoanHlebarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, this works as it should but there are a couple of things that you may need to change.
One is to ensure you are formatting your code correctly. This makes reading the code easier and helps other developers understand at a glance what is going on.

Secondly, this PR should only have files associated with the Form Control task. Here you have also addded the Wireframe task files. Please remove those as they are not relevant to this PR.

placeholder="Enter your full name"
/>
</div>
<br>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stick to regular formatting (spacing) of the code so that it is easier to read. You can use the Prettier extension in VSCode and set it up to automatically format your files when you save. I would recommend you to have a look at it and enable it in the settings of VSCode.

Otherwise, please format the file so that each element is indented correctly.

@YoanHlebarov YoanHlebarov added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 11, 2025
@chibu0070 chibu0070 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 11, 2025
Copy link

@YoanHlebarov YoanHlebarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice this is much neater now. Good job I am happy with this now.

@YoanHlebarov YoanHlebarov added Reviewed Volunteer to add when completing a review with trainee action still to take. Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Onboarding The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants