WM | 25-ITP-May | Nahom Mesfin | Sprint 2 coursework #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nahommesfin77
added
the
Needs Review
LonMcGregor
added
Review in progress
LonMcGregor
reviewed
Jul 22, 2025
Sprint-2/1-key-errors/1.js
Outdated
|
|
||
| // Finally, correct the code to fix the problem | ||
| // =============> write your new code here | ||
| function convertToPercentage(decimalNumber) { | ||
| decimalNumber = 0.5; // Remove 'const' to avoid redeclaration |
There was a problem hiding this comment.
If you do this, what will happen if Irun the code with a different parameter? Like covertToPercentage(0.7)?
There was a problem hiding this comment.
Ah i see, convertToPercentage(0.7) will log 50% because I have already assigned the value to be 0.5. I will fix the issue just by removing the value declartion decimalNumber = 0.5; and It will give the correct result which is 70%
LonMcGregor
added
Reviewed
nahommesfin77
added
the
Needs Review
|
Great work, you're done with this sprint now |
LonMcGregor
added
Complete
nahommesfin77
removed
the
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
In Errors, I predicted and verified error messages by running files and explained their causes. In Debug, I identified why programs misbehave, tested predictions, and fixed the code. In Implement, I wrote functions based on given requirements and tested them with various inputs. In Interpret, I analyzed larger programs using mdn web doc and other sources to understand unfamiliar code and fix the code.