Manchester | 25-ITP-May | Jennifer Isidienu | Sprint 1 | Coursework #683
Conversation
JenniferIsidienu
added
the
Needs Review
There was a problem hiding this comment.
-
Code is well written and explanation is clear. Well done.
-
Why not practice "committing files one by one, on purpose, and for a reason"?
In VSCode, you can select which file to stage, and commit only the staged file.
See: https://www.youtube.com/watch?v=z5jZ9lrSpqk&t=705 (At around 12:50 minute marker, the video shows how to stage a single file).
| // 5. const pence = paddedPenceNumberString.substring | ||
| // (paddedPenceNumberString.length - 2).padEnd(2, "0"): | ||
| // extracts the pence part of the string by taking the last two characters | ||
| // and ensuring it has exactly 2 characters by padding with zeros if necessary. |
There was a problem hiding this comment.
Could we expect this program to work as intended for any valid penceString if we deleted .padEnd(2, "0") from the code?
In other words, do we really need .padEnd(2, "0") in this script?
There was a problem hiding this comment.
I think it's needed because the program may not work as intended if we deleted. Am I correct?
There was a problem hiding this comment.
Why don't you try executing the script without using padEnd(2, '0'), and test it with different values of penceString to validate your expectation?
There was a problem hiding this comment.
Everything still works fine. It seems that .padstart(3, "0") already ensures the string has at least 3 characters. So, when we extract the last two characters for the pence part, no extra padding is needed afterward.
Thanks a lot!
cjyuan
added
Reviewed
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.