ZA Cape Town | ITP-May-2025 | Dawud Vermeulen | Module-Structuring and Testing Data Sprint-3 #688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dave-Vermeulen
added
the
Needs Review
illicitonion
added
Review in progress
illicitonion
reviewed
Aug 6, 2025
| } | ||
| const rank = card.slice(0, -1); | ||
| if (rank === "A") return 11; | ||
| else if (rank === "J", "Q", "K") return 10; |
There was a problem hiding this comment.
Each line of your code here seems to be getting more and more indented, even though there aren't any {s - please can you format your code consistently so it's easier to read.
This applies to all of your code in this PR.
| return 11; | ||
| const rank = card.slice(0, -1); // works to extract the rank and ignores the suit | ||
| if (rank === "A") return 11 //works | ||
| else if (["J", "Q", "K", "10"].includes(rank)) |
There was a problem hiding this comment.
In your other implementation you included 10 in the 2-9 case, but in this one you're including it in the J/Q/K case - both work, but can you talk through which you think is simpler?
| // Case 5: Handle Invalid Cards: | ||
| test("should throw an error for invalid card", () => { | ||
| expect(() => getCardValue("Z♠")).toThrow("Invalid card rank."); //not sure how to write this test |
There was a problem hiding this comment.
You have a comment here saying you're not sure how, but it looks like you have - is it something you want to talk through, or if not, please remove the comment :)
| if (num === 1) return "1st"; | ||
| if (num === 2) return "2nd"; | ||
| if (num === 3) return "3rd"; | ||
| return num + "th"; // handles all cases >= 4 |
illicitonion
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed all exercises in the following subfolders:
Questions
Please review my code 🪻🙏🏽