-
-
Notifications
You must be signed in to change notification settings - Fork 197
London | May 2025 | Victoria Scott | Sprint 2 Coursework #690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
London | May 2025 | Victoria Scott | Sprint 2 Coursework #690
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Code looks good.
-
To keep this branch clean, you should keep only modified files in the Sprint-2 folder in this branch. It seems that the current branch was created from your
Sprint-1
branch instead of frommain
. Can you rebase this branch ontomain
? -
You should also practice "committing files one by one, on purpose, and for a reason" in future PR. In VSCode, you can select which file to stage, and commit only the staged file. See: https://www.youtube.com/watch?v=z5jZ9lrSpqk&t=705 (At around 12:50 minute marker, the video shows how to stage a single file).
function capitalise(str) { | ||
let capitalisedStr = `${str[0].toUpperCase()}${str.slice(1)}`; | ||
return capitalisedStr; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is correct but indentation is off.
Here are the instructions to rebase your branch onto In your case, Important:
1. Open Your Cloned Repository in VSCode and Start a Terminal in VSCode.VSCode will start the terminal in the top-level folder of the current project. 2. Switch to the branch you want to rebase (
|
Self checklist
Changelist
Answers to sprint 2 questions