London | 25-SDC-Nov | Zohreh Kazemianpour | Sprint 5 | Laptop-allocation #314
+138
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dness scores and improve overall allocation quality
zohrehKazemianpour
added
the
Needs Review
OracPrime
added
the
Review in progress
OracPrime
reviewed
Jan 11, 2026
OracPrime
left a comment
OracPrime
left a comment
There was a problem hiding this comment.
Some intelligent coding here, nice!
Couple of questions to clear up, but overall good work.
| name: str | ||
| age: int | ||
| # Sorted in order of preference, most preferred is first. | ||
| preferred_operating_system: tuple |
| raise ValueError("Not enough laptops to allocate one per person") | ||
|
|
||
|
|
||
| people_sorted = sorted(people, key = lambda p: len(p.preferred_operating_system)) |
There was a problem hiding this comment.
Nice touch - haven't seen anyone else do this, but it is a clever tweak to the algorithm
| people_sorted = sorted(people, key = lambda p: len(p.preferred_operating_system)) | ||
|
|
||
| result={} | ||
| available_laptops = laptops.copy() |
There was a problem hiding this comment.
Good spot that you need the copy if you don't want to change the original
| sadness = calculate_sadness(person, laptop) | ||
| if sadness < smallest_sadness: | ||
| smallest_sadness = sadness | ||
| best_laptop = laptop |
There was a problem hiding this comment.
You could of course break out of the loop if sadness is 0
|
|
||
| return result | ||
|
|
||
| allocate_laptops(people, laptops) |
There was a problem hiding this comment.
Why is this first call to allocate laptops here?
OracPrime
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This PR implements laptop allocation.