Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

London | Nadika Zavodovska | Module-Tools | Sprint 2 | JQ #35

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

London | Nadika Zavodovska | Module-Tools | Sprint 2 | JQ #35

wants to merge 11 commits into from

Conversation

nadika-zavodovska
Copy link

Hi,

I've done all the tasks for the jq.

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Thank you.

@nadika-zavodovska nadika-zavodovska added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Participant to add when requesting review labels Mar 7, 2025
@nadika-zavodovska nadika-zavodovska mentioned this pull request Mar 14, 2025
Open
ehwus
ehwus reviewed Mar 18, 2025
View reviewed changes
Copy link

@ehwus ehwus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All scripts read nicely and when I've run them are outputting what we would expect. You've understood how to use jq very well, keep it up!

@ehwus ehwus added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Mar 18, 2025
@nadika-zavodovska
Copy link
Author

All scripts read nicely and when I've run them are outputting what we would expect. You've understood how to use jq very well, keep it up!

Thank you, @ehwus Alex, for reviewing my tasks. Your comment inspires me to keep improving and doing my best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehwus ehwus ehwus left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Reviewed Volunteer to add when completing a review 📅 Sprint 2 Assigned during Sprint 2 of this module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nadika-zavodovska @ehwus