CYF London | Rihanna Poursoltani | Module-Tools | Sprint 2 | Shell Pipelines #36
Conversation
RihannaP
added
📅 Sprint 2
| @@ -4,3 +4,5 @@ set -euo pipefail | |||
|
|
|||
| # TODO: Write a command to output the names of the files in the sample-files directory whose name contains at least one upper case letter. | |||
| # Your output should contain 11 files. | |||
| ls -1 ./sample-files | grep '[A-Z]' | |||
| ls -1 ./sample-files | grep '[A-Z]' | wc -l | |||
There was a problem hiding this comment.
praise: Great to see that you've built in these 'tests' to your script, and good use of some of the other tooling that we've been learning to do it!
| @@ -5,3 +5,4 @@ set -euo pipefail | |||
| # The input for this script is the scores-table.txt file. | |||
| # TODO: Write a command to output scores-table.txt, with shows the line for the player whose first score was the second highest. | |||
| # Your output should be: "Piotr Glasgow 15 2 25 11 8" (without quotes). | |||
| sort -k3 -rn ./scores-table.txt | tail -n+2 | head -n1 | |||
There was a problem hiding this comment.
question: This works well, but could we make this more efficient by using one program rather than both head and tail?
| @@ -6,3 +6,5 @@ set -euo pipefail | |||
| # TODO: Write a command to show a list of all events that have happened, without duplication. | |||
| # The order they're displayed doesn't matter, but we never want to see the same event listed twice. | |||
| # Your output should contain 6 lines. | |||
| sort -u ./events.txt #with -u option | |||
| sort ./events.txt | uniq #with pipe output of sort to the input of uniq | |||
There was a problem hiding this comment.
question: Which of these do you think is better? Are there any tradeoffs here?
While also great to see your working, it's probably best to comment out any duplication here as technically this script will output what we're expecting twice.
| @@ -5,3 +5,5 @@ set -euo pipefail | |||
| # The input for this script is the events.txt file. | |||
| # TODO: Write a command to show how many times anyone has entered and exited. | |||
| # It should be clear from your script's output that there have been 5 Entry events and 4 Exit events. | |||
| sort ./events.txt | uniq -c #show Exit and Entry per person | |||
There was a problem hiding this comment.
question: again it's good to see your working here, but let's comment out the first part as it doesn't exactly meet the specification
| @@ -6,3 +6,4 @@ set -euo pipefail | |||
| # TODO: Write a command to show how many times anyone has entered and exited. | |||
| # It should be clear from your script's output that there have been 5 Entry events and 4 Exit events. | |||
| # The word "Event" should not appear in your script's output. | |||
| tail -n+2 ./events-with-timestamps.txt |sort -k3 | awk '{print $3}'| uniq -c | |||
There was a problem hiding this comment.
nitpick: this is a great use of pipes and meets the criteria, but is the formatting and whitespace of this line consistent with the rest of your scripts?
| @@ -6,3 +6,4 @@ set -euo pipefail | |||
| # The author got feedback that they're using too many exclamation marks (!). | |||
| # | |||
| # TODO: Write a command to output the contents of text.txt with every exclamation mark (!) replaced with a full-stop (.). | |||
| cat text.txt | tr '!' '.' | |||
There was a problem hiding this comment.
question: this works well, but can you think of a way for tr to have access to the file directly so that you don't have to run two programs?
ehwus
added
Reviewed
Self checklist