Skip to content

CYF London | Rihanna Poursoltani | Module-Tools | Sprint 2 | Shell Pipelines #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

CYF London | Rihanna Poursoltani | Module-Tools | Sprint 2 | Shell Pipelines #36

wants to merge 4 commits into from

Conversation

@RihannaP
Copy link

@RihannaP RihannaP commented Mar 7, 2025 •
edited
Loading

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

@RihannaP RihannaP added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 7, 2025
ehwus
ehwus reviewed Mar 18, 2025
View reviewed changes
Copy link

@ehwus ehwus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work Rihanna, you've understood shell pipelines well and built on clearly very strong foundational shell tool knowledge. All of the scripts ran on my machine and the outputs were all exactly what was required. Keep it up!

@ehwus ehwus added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 18, 2025
@RihannaP RihannaP added the Complete Volunteer to add when work is complete and all review comments have been addressed. label May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ehwus ehwus ehwus left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RihannaP @ehwus