London | Elhadj Abdoul Diallo| Module-Tools | WEEK4 - Implement-cowsay #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 6, 2025 19:11
…ion and message input
eediallo
added
the
Needs Review
implement-cowsay/cow.py
Outdated
| import argparse | ||
|
|
||
| parser = argparse.ArgumentParser(description="Make animals say things") | ||
| parser.add_argument('--animal', choices=cowsay.char_names, help="The animal to be saying things", default="cow") |
There was a problem hiding this comment.
It's not a problem, but is a bit unusual to have mixed quotes (some of the strings on this line are wrapped in 's and others "s) - is there a reason to prefer one over the other? Or a reason you used different ones here?
There was a problem hiding this comment.
No reason to be honest. Python accept both. I know I should pick one and be consistent with it.
There was a problem hiding this comment.
Makes sense :) Personally I prefer "s because it's more often that I write a string containing a ' than a ", e.g. I will often write a string literal like "I don't know" but I less often write a string literal like 'I said "hello"'
illicitonion
added
Reviewed
illicitonion
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist