London | Elhadj Abdoul Diallo| Module-Tools | WEEK4 - Implement-cowsay - #39
London | Elhadj Abdoul Diallo| Module-Tools | WEEK4 - Implement-cowsay#39eediallo wants to merge 9 commits into
Conversation
![[Elhadj Abdoul Diallo]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
…ion and message input
eediallo
added
the
Needs Review
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
Looking good - I left a few questions to ponder :)
| import argparse | ||
|
|
||
| parser = argparse.ArgumentParser(description="Make animals say things") | ||
| parser.add_argument('--animal', choices=cowsay.char_names, help="The animal to be saying things", default="cow") |
There was a problem hiding this comment.
It's not a problem, but is a bit unusual to have mixed quotes (some of the strings on this line are wrapped in 's and others "s) - is there a reason to prefer one over the other? Or a reason you used different ones here?
There was a problem hiding this comment.
No reason to be honest. Python accept both. I know I should pick one and be consistent with it.
There was a problem hiding this comment.
Makes sense :) Personally I prefer "s because it's more often that I write a string containing a ' than a ", e.g. I will often write a string literal like "I don't know" but I less often write a string literal like 'I said "hello"'
illicitonion
added
Reviewed
illicitonion
added
Complete
|
Closing PR because the SDC run has finished. Feel free to re-open if you're still working on it. |
2 participants
Learners, PR Template
Self checklist