Skip to content

London SDC | Anna Fedyna | Module Tools| Individual shell | Week 1 #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
annafedyna wants to merge 7 commits into
base: main
Choose a base branch
from
Open

London SDC | Anna Fedyna | Module Tools| Individual shell | Week 1 #40

annafedyna wants to merge 7 commits into from

Conversation

@annafedyna
Copy link

@annafedyna annafedyna commented Mar 10, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@annafedyna annafedyna added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 10, 2025
ehwus
ehwus reviewed Mar 16, 2025
View reviewed changes
Copy link

@ehwus ehwus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great submission that demonstrates good engagement and understanding of each of the programs that you were working with, as well as great Bash scripting skills. There are a few comments where your attention to detail could be improved, it's always prudent to double check the output of your scripts to make sure that they match the specifications ahead of submitting your work for review.

Overall a very solid effort and great work!

individual-shell-tools/grep/script-04.sh
# TODO: Write a command to output every line in dialogue.txt that does not contain the word "Hello" (regardless of case).
# The output should contain 10 lines.

grep -vic 'Hello' dialogue.txt
Copy link

@ehwus ehwus Mar 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: We're using grep twice here, and the output on one is 10 lines and the output on the other is 1 line. We can definitely do this correctly in one, can you work out which flag (or flags) we might need to do this?

Copy link
Author

@annafedyna annafedyna Mar 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, leaving -vi flags going to be enough. If there is any other way would be nice to now)

@ehwus ehwus added Complete Volunteer to add when work is complete and all review comments have been addressed. Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Complete Volunteer to add when work is complete and all review comments have been addressed. labels Mar 16, 2025
@annafedyna
Copy link
Author

annafedyna commented Mar 16, 2025

@ehwus Thank you a lot for the review! I really appreciate valuable feedback !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ehwus ehwus ehwus left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@annafedyna @ehwus