Skip to content

LONDON SDC | Anna Fedyna | Module-Tools | Sprint 2 | Week 2 | JQ #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
annafedyna wants to merge 1 commit into
base: main
Choose a base branch
from
Open

LONDON SDC | Anna Fedyna | Module-Tools | Sprint 2 | Week 2 | JQ #46

annafedyna wants to merge 1 commit into from

Conversation

@annafedyna
Copy link

@annafedyna annafedyna commented Mar 17, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@annafedyna annafedyna added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 18, 2025
@annafedyna annafedyna changed the title LONDON SDC | Anna Fedyna | Module-Tools | Sprint 2 | Week 2 LONDON SDC | Anna Fedyna | Module-Tools | Sprint 2 | Week 2 | JQ Mar 18, 2025
mjpeet
mjpeet reviewed Mar 20, 2025
View reviewed changes
Copy link

@mjpeet mjpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've demonstrated a solid understanding of jq's capabilities, such as string interpolation and the join function. You've carefully followed the requirements, ensuring the output format is exactly as specified. This level of precision is a great habit to develop as a programmer. By tackling these exercises, you're not only learning jq but also improving your ability to think critically and solve problems programmatically. Keep up the great work! (i left one comment)

@mjpeet mjpeet added 📅 Sprint 2 Assigned during Sprint 2 of this module Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 20, 2025
@annafedyna
Copy link
Author

annafedyna commented Mar 20, 2025

@mjpeet Thank you for the detailed and encouraging feedback! I really appreciate you highlighting the specific aspects of my work )

@mjpeet mjpeet added the Complete Volunteer to add when work is complete and all review comments have been addressed. label Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mjpeet mjpeet mjpeet left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@annafedyna @mjpeet