Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LONDON SDC | Pooriya Ketabi | Module-Tools | Sprint-1 | Number systems exercises #55

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

PooriyaKTB
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@PooriyaKTB PooriyaKTB added the Needs Review Participant to add when requesting review label Mar 31, 2025
Copy link

@mjpeet mjpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on the binary number conversion solutions! Your answers are accurate, and the additional explanations really show your thought process, which is fantastic.

However, I noticed that some unrelated files might have been included in the same pull request. It would be a good idea to double-check the changes in Git to ensure only the relevant files for the binary number conversion solution are part of this PR. )i think you accidentally also added the solutions to Individual shell tools as well?)

@mjpeet mjpeet added 👀 Review Git Changes requested to do with Git Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👀 Review Git Changes requested to do with Git Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants