Skip to content

LONDON | DONARA BLANC | SHELL TOOLS - PYTHON | SPRINT 4 #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

donarbl
Copy link

@donarbl donarbl commented May 2, 2025

Learners, PR Template

Self checklist

  • [X ] I have committed my files one by one, on purpose, and for a reason
  • [ X] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • [X ] I have tested my changes
  • [X ] My changes follow the style guide
  • [X ] My changes meet the requirements of this task

Changelist

Implemented shell tools using Python and interestingly, quite enjoyed the process.

Questions

Ask any questions you have for your reviewer.

@donarbl donarbl added 📅 Sprint 4 Assigned during Sprint 4 of this module Needs Review Participant to add when requesting review labels May 2, 2025
Copy link

@chinar-amrutkar chinar-amrutkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a general rule of thumb, it is always helpful to add short comments in the code explaining your logic. Looks good otherwise :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review Participant to add when requesting review 📅 Sprint 4 Assigned during Sprint 4 of this module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants