Skip to content

Cape Town| 25-SDC-July | Faith Muzondo | Sprint 1 | Number systems #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Cape Town| 25-SDC-July | Faith Muzondo | Sprint 1 | Number systems #83

wants to merge 1 commit into from

Conversation

Faithy4444
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@Faithy4444 Faithy4444 added the Needs Review Participant to add when requesting review label Jul 15, 2025
@chinar-amrutkar chinar-amrutkar self-assigned this Jul 16, 2025
@chinar-amrutkar chinar-amrutkar added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jul 20, 2025
chinar-amrutkar
chinar-amrutkar reviewed Jul 20, 2025
View reviewed changes
Copy link

@chinar-amrutkar chinar-amrutkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start. However, I can see you have included several different exercises in this PR. Please create a new PR which only includes the Number Systems exercise :)

@chinar-amrutkar chinar-amrutkar added Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 20, 2025
@Faithy4444
Copy link
Author

my apologies, I made another branch the parent branch by mistake. Fixed it now

chinar-amrutkar
chinar-amrutkar approved these changes Jul 22, 2025
View reviewed changes
Copy link

@chinar-amrutkar chinar-amrutkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well done!

@chinar-amrutkar chinar-amrutkar removed the Needs Review Participant to add when requesting review label Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chinar-amrutkar chinar-amrutkar chinar-amrutkar approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@chinar-amrutkar chinar-amrutkar

Labels
Reviewed Volunteer to add when completing a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Faithy4444 @chinar-amrutkar