London | 25-SDC-July | Andrei Filippov | Sprint 1 | Individual shell tools exercises #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Droid-An
added
Needs Review
LonMcGregor
added
Review in progress
LonMcGregor
reviewed
Jul 31, 2025
There was a problem hiding this comment.
It should be possible to solve this task with a single cat command - no pipes needed. If you have time for this stretch, you could have another look at this
| @@ -4,3 +4,4 @@ set -euo pipefail | |||
|
|
|||
| # TODO: Write a command to output the name of every `.txt` file in this directory which contains a line of dialogue said by the Doctor. | |||
| # The output should contain two filenames. | |||
| grep -lr --include="*.txt" '^Doctor:' | |||
There was a problem hiding this comment.
This works, but is there a particular reason you used --include here rather than passing this as the final argument? Do you know the difference?
LonMcGregor
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
done exercises
Questions
no questions