fix(modal + dialog): updating aria attributes per a11y team feedback#3063
Merged
codecademydev merged 18 commits intomainfrom Apr 21, 2025
Merged
fix(modal + dialog): updating aria attributes per a11y team feedback#3063codecademydev merged 18 commits intomainfrom
codecademydev merged 18 commits intomainfrom
Conversation
|
View your CI Pipeline Execution ↗ for commit 9dd0588. ☁️ Nx Cloud last updated this comment at |
… and testing instructions
LinKCoding
commented
Apr 8, 2025
dreamwasp
approved these changes
Apr 15, 2025
Contributor
dreamwasp
left a comment
There was a problem hiding this comment.
tested locally and works great ✨
aresnik11
reviewed
Apr 17, 2025
aresnik11
approved these changes
Apr 17, 2025
Contributor
aresnik11
left a comment
There was a problem hiding this comment.
There isnt a testing section anymore but Modal/Dialog existing examples sound great!
Collaborator
📬Published Alpha Packages:@codecademy/gamut@62.0.1-alpha.9dd058.0 |
Collaborator
|
🚀 Styleguide deploy preview ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Applying changes to the Modal and Dialog components per feedback from a11y team.
Also adding a zIndex
PR Checklist
Testing Instructions
The feedback from the a11y team:
PR Links and Envs