Skip to content

Comments

fix(modal + dialog): updating aria attributes per a11y team feedback#3063

Merged
codecademydev merged 18 commits intomainfrom
kl-gm-1055
Apr 21, 2025
Merged

fix(modal + dialog): updating aria attributes per a11y team feedback#3063
codecademydev merged 18 commits intomainfrom
kl-gm-1055

Conversation

@LinKCoding
Copy link
Contributor

@LinKCoding LinKCoding commented Apr 4, 2025

Overview

Applying changes to the Modal and Dialog components per feedback from a11y team.
Also adding a zIndex

PR Checklist

Testing Instructions

The feedback from the a11y team:

  1. Go to the preview
  2. Navigate to Modal
  3. Turn on VO, and click the button to open the modal - it should announce the title of the modal, that it's a dialog (yes, that's not a typo), and how many items are inside the modal (this is the same behavior as prod)
  4. Navigate to Dialog (skip the TESTING section for now)
  5. With VO on, click on the button to open the dialog — it should announce the title of the dialog, that it's a dialog , and how many items are inside the dialog (this also is the same behavior as prod)
  6. Go back to the TESTING ... section
  7. Follow the instructions in the story itself
  8. ...
  9. Profit!

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env

@nx-cloud
Copy link

nx-cloud bot commented Apr 4, 2025

View your CI Pipeline Execution ↗ for commit 9dd0588.


☁️ Nx Cloud last updated this comment at 2025-04-21 15:04:44 UTC

@LinKCoding LinKCoding changed the title applied feedback to modal fix(modal + dialog): updating aria attributes per a11y team feedback Apr 4, 2025
@LinKCoding LinKCoding marked this pull request as ready for review April 10, 2025 14:49
@LinKCoding LinKCoding requested a review from a team as a code owner April 10, 2025 14:49
Copy link
Contributor

@dreamwasp dreamwasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally and works great ✨

Copy link
Contributor

@aresnik11 aresnik11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isnt a testing section anymore but Modal/Dialog existing examples sound great!

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/gamut@62.0.1-alpha.9dd058.0
@codecademy/gamut-kit@0.6.498-alpha.9dd058.0
@codecademy/styleguide@73.0.1-alpha.9dd058.0

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://68065ea0100a190e375313e4--gamut-preview.netlify.app

Deploy Logs

@LinKCoding LinKCoding added the Ship It :shipit: Automerge this PR when possible label Apr 21, 2025
@codecademydev codecademydev merged commit 36b0fd0 into main Apr 21, 2025
20 of 21 checks passed
@codecademydev codecademydev deleted the kl-gm-1055 branch April 21, 2025 15:07
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants