feat(Modal)!: add multiview options for back and danger variant#3067
feat(Modal)!: add multiview options for back and danger variant#3067codecademydev merged 9 commits intomainfrom
Conversation
|
View your CI Pipeline Execution ↗ for commit 661360c. ☁️ Nx Cloud last updated this comment at |
aresnik11
changed the title
LinKCoding
left a comment
LinKCoding
left a comment
There was a problem hiding this comment.
Left some thoughts, but nothing blocking :)
Love the new examples and tests!!
| onRequestClose: mockRequestClose, | ||
| }); | ||
|
|
||
| describe('Modal', () => { |
| }); | ||
|
|
||
| describe('Multi view', () => { | ||
| it('renders modal title and view children when modal title is provided', () => { |
There was a problem hiding this comment.
great, test — it made me think that it'd be helpful to callout this info in the story as well.
In the #Multi View section, maybe something like:
Each view can also take a title that renders as a heading. However, if the Modal already has a title in the parent element then that value will be the title rendered instead of the view's title.
There was a problem hiding this comment.
sure! yeah this was confusing when i was writing the test
dreamwasp
left a comment
dreamwasp
left a comment
There was a problem hiding this comment.
looks great, love the new tests + views
📬Published Alpha Packages:@codecademy/gamut@61.1.3-alpha.661360.0 |
|
🚀 Styleguide deploy preview ready! |
4 participants
Overview
Adds bi-directional option for multiview modals, refactors the CTAs in multiview modals, and adds danger variant. Adds unit tests and additional stories.
PR Checklist
Testing Instructions
PR Links and Envs