-
-
Notifications
You must be signed in to change notification settings - Fork 289
[LANG] Add Russian(Русский) and Cyrillic support #777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
btw if the translation is the same as the original, you can delete the line if showMissingIds is not present or false; its gonna use the default language one (in this case english) so no need to re-add certain lines, they just make the file longer |
what exactly do you mean by that? |
well for example you left all of the playstate ratings |
I just copied the whole translate from another pull request. I'll fix it later |
I gonna cry😭
done |
re-export
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good PR, but in the future I feel like we should adapt the hasCyrillic
function so it generally handles non-latin writing systems (such as Greek or even the Japanese Syllabaries, Thai writing, etc)
I have added support for all major Cyrillic characters from “А” to “Я” as basic isDefault characters. Now it will be possible to add such languages as: Russian, Ukrainian, Belarusian, and others that use Cyrillic as the basis for their alphabets.
The only thing limitation, related to with Cyrillic alphabets is the window title. Since lime on its part does not accept these characters, I could not do anything and now I just display the text in English.
The translation, the bold (and possibly the normal) fonts, as well as all the assets of other things will be finalized later, if you allow the addition of Cyrillic.