Update query parameters handling and fix theme application on share page #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed the issue where the theme parameter passed to the share page wasn't being applied. - Addressed styling inconsistencies related to theme display on the share page.
- Use `some` instead of `findIndex` to check for a valid theme - Add `showSafariHeader` and `showAttribution` query parameters - Default values for `showSafariHeader` and `showAttribution` are set to true unless explicitly specified as 'false'
👷 Deploy request for green-wall-x pending review.Visit the deploys page to approve it
|
|
这个 pr 改动还是比较小的，我觉得可以直接合，剩下的 bug 我应该在下一个 pr 里修 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theme Validation Improvement
SharePage.tsxby replacing thefindIndexcheck with a more conciseArray.somecheck.THEME_PRESETS), the default theme is correctly applied.New Query Parameters
showSafariHeaderandshowAttribution.trueunless explicitly set to'false'in the URL query string.ShareButton.tsxcomponent to include these parameters in the generated share URL when their corresponding settings arefalse.Styling Fixes
Chores
Closes Bump next from 14.1.0 to 14.1.1 #26 Bump braces from 3.0.2 to 3.0.3 #27 (had been fixed in pr Add Safari header toggle, update dependencies, and improve styles #29)