Skip to content

chore: refactor core cmake file #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepin-ci-robot merged 1 commit into from
Apr 25, 2025
Merged

chore: refactor core cmake file #1110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/plugins/core/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,7 @@ project(core)

if(${CMAKE_SYSTEM_PROCESSOR} STREQUAL "mips64")
add_definitions(-DUNSUPPORTPLATFORM)
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (typo): Possible typo: UNSUPPORTPLATFORM should be UNSUPPORTEDPLATFORM

It appears there might be a typo in the macro definition. Did you mean to use UNSUPPORTEDPLATFORM instead of UNSUPPORTPLATFORM?

Suggested change
add_definitions(-DUNSUPPORTPLATFORM)
add_definitions(-DUNSUPPORTEDPLATFORM)

message(STATUS "Skipping WebEngineWidgets for mips64 platform.")
else()
find_package(Qt${QT_VERSION_MAJOR} COMPONENTS WebEngineWidgets REQUIRED)
target_link_libraries(${PROJECT_NAME} Qt${QT_VERSION_MAJOR}::WebEngineWidgets)
message(STATUS "Skipping WebEngineWidgets for ${CMAKE_SYSTEM_PROCESSOR} platform.")
endif()

FILE(GLOB_RECURSE PROJECT_SOURCES
Expand All @@ -34,4 +31,9 @@ target_link_libraries(${PROJECT_NAME}
${DtkWidget_LIBRARIES}
)

if(NOT ${CMAKE_SYSTEM_PROCESSOR} STREQUAL "mips64")
find_package(Qt${QT_VERSION_MAJOR} COMPONENTS WebEngineWidgets REQUIRED)
target_link_libraries(${PROJECT_NAME} Qt${QT_VERSION_MAJOR}::WebEngineWidgets)
endif()

install(TARGETS ${PROJECT_NAME} LIBRARY DESTINATION ${PLUGIN_INSTALL_PATH})
Loading