Repository navigation
feat: Add parents parameter for team resource - #10
Open
svdimchenko wants to merge 1 commit into
Open
svdimchenko wants to merge 1 commit into
svdimchenko wants to merge 1 commit into
Conversation
svdimchenko
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multi-version acceptance tests + team parents fix
Parameterize docker-compose.yml with ${OPENMETADATA_VERSION} so a single compose file covers all versions. Switch MySQL to a named volume so down -v fully cleans the DB between runs (fixes migration-related test failures).
Add docker/test/versions listing supported versions (1.12.4, 2.0.3). make testacc OM_VERSION=2.0.3 runs against a specific version; make testacc-all iterates all of them.
Replace the single acceptance CI job with a matrix over both versions (fail-fast: false).
Fix openmetadata_team resource: resolve parent names to UUIDs before sending (the CreateTeam API expects parents: [uuid], not entity ref objects), and preserve the parents value in state instead of overwriting it with null after apply.
Add TestAccTeamResourceWithParents acceptance test covering the child-under-parent scenario.
Checklist
make testandmake lintpassmake testacc), or CI has run themmake docsre-run,docs/committed, andexamples/updatedprovider.goand has an acceptance test