Repository navigation
ci: run acceptance tests only for provider changes - #9
Merged
Merged
Conversation
Doc, example and config-only changes were starting a full OpenMetadata stack for nothing. Filter the workflow on the paths that can affect the result. Acceptance Tests is no longer a required status check: a path-filtered workflow never reports, which would block every unrelated PR. lint and build stay required and still run on everything. Also passes the workflow_dispatch version input through env rather than interpolating it into the shell. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #7 with the simple version.
Doc, example and config-only changes were starting a full OpenMetadata stack (MySQL + Elasticsearch + OM server) to prove nothing. The workflow is now filtered on the paths that can affect the result:
internal/,main.go,go.mod,go.sum,docker/test/,scripts/testacc.sh, and the workflow itself.Required-check change
Acceptance Testshas been removed from the required status checks onmain. This is mandatory, not incidental: a workflow skipped by apaths:filter never reports its check, so every doc-only PR would sit at "Expected" and could never merge — the same failure that made the first migration PR un-mergeable.lint,buildandEvery resource has an acceptance testremain required and still run on every PR; together they run in well under a minute.Trade-off: the acceptance suite still runs on every provider change and stays visible, but it no longer blocks the merge button. With approvals at 0, that means a red acceptance run can be merged past if someone ignores it.
Also
The
workflow_dispatchversion input reachessedthroughenv:instead of being interpolated into the shell. It needs write access to set, so it was not an outsider risk, but it was an injection point.No YAML anchors — GitHub Actions does not support them, so the path list is written out twice.
🤖 Generated with Claude Code