Audio changes - #5593
Conversation
|
Leaving a reminder to set some memory bounds and that 64mb is alright for a minimum. |
|
Keys with dashes in them (yaml__lavalink__server__gc-warnings, yaml__logging__file__max-history, and yaml__logging__file__max-size) can't be registered in Config as - can't be used. |
|
Also if you're interested, something that could fit in this PR is the non existent llset settings needed for Cog-Creators/Red-Lavalink#107 (but there's also RLL work to do there, too, to support them). |
|
I had a bot with an external lavalink server set, then loaded this PR/cog after editing the config values for the application.yml creation, just to test... |
… tries - have a base 7 backoff.
5ea66d8 to
21a53ee
Compare
… tries - have a base 7 backoff.
0cd556d to
2b1eef6
Compare
1f1cd70 to
bba5488
Compare
…iendly names - Change Xms to "Initial Heapsize" - Change Xmx to "Max Heapsize" Signed-off-by: Draper <27962761+Drapersniper@users.noreply.github.com>
1 - Allow configuringJava's
-Xmxflag (supersedes #5542)2 - Replace the application.yml in favor of config storage.
3 - Allow toggling sources on and off
4 - Allow changing the managed node binding IP, password, and port.
5 - Allow customizing the framebuffer and NAS buffer
6 - Framework to modify the application YAML is baked in, all it takes to add more stuff (plugins for example) if following the structure currently present.
7 - Added captcha for bot owners for specific
llsetcommands8 - Reduce the number of config calls in
cog_before_invokeby 49 - Unify all defaults into a single location to make changing them easier in the future
10 - Add
llset resetwhich resets all changes made byllset11 - Update docstring for all
llsetsubcommands12 -
llset host|password|portare now only usable if you first enable an external Lavalink server.13 -
llset infoupdate14 -
llset yamladded15 -
audioset infoupdated16 -
-Xms64Malways set.17 -
llsetcommands will not be available depending on Node mode (i.ellset configwill not be available if you run an external mode,llset passwordwill not be available if you run a managed node)18 - Too many fixes to mention all of them around the shutdown and reconnection logic
19 -
llset securedaddedDepends on:
Cog-Creators/Red-Lavalink#118Cog-Creators/Red-Lavalink#117
Cog-Creators/Red-Lavalink#116
Cog-Creators/Red-Lavalink#115
Cog-Creators/Red-Lavalink#114
To Test use: Cog-Creators/Red-Lavalink#113
Before merging there are TODO's and dependencies changes required in the PR which are in place now just to facilitate testing