Fix issue with PR paths for embedding linker workflow#419
Merged
Conversation
The previous path was incorrect which meant the workflow didn't run at PR time.
| paths: | ||
| - 'medcat-plugins/medcat-embedding-linker/**' | ||
| - '.github/workflows/medcat-embedding-linker**' | ||
| - '.github/workflows/embedding-linker**' |
Collaborator
There was a problem hiding this comment.
Hey I dont think this is right?
The file name is .github/workflows/medcat-embedding-linker_ci.yml ?
Collaborator
Author
There was a problem hiding this comment.
Yep - you're right - fixed the wrong one
This reverts commit c18e9f9.
Collaborator
Author
|
PS: |
alhendrickson
approved these changes
Apr 24, 2026
alhendrickson
left a comment
alhendrickson
left a comment
Collaborator
There was a problem hiding this comment.
Approved - feels reasonable to merge this in, and then prove the other branch makes the build pass again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous path was incorrect which meant the workflow didn't run at PR time.