feat(medcat-trainer-client): Support OIDC in medcat trainer client#428
Merged
alhendrickson merged 4 commits intoMay 11, 2026
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jocelyneholdbrook
approved these changes
May 11, 2026
mart-r
reviewed
May 11, 2026
|
|
||
| token = get_keycloak_access_token(kc_settings) | ||
| self.headers = {"Authorization": f"Bearer {token}"} | ||
| return |
Collaborator
There was a problem hiding this comment.
I feel like the early return could bite us in the bum later down the road.
I.e I feel like the 2 different auth / header getting methods should be moved outside the __init__ and called in if/else manner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.