WebAssembly/Clang Update #8
Closed
+107
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YangJiao1996
force-pushed
the
feature/rttr-webassembly-update
branch
2 times, most recently
from
092e3ee to
fc40694
Compare
ninloot
approved these changes
Oct 26, 2021
ninloot
approved these changes
Oct 26, 2021
ninloot
approved these changes
Oct 26, 2021
ninloot
reviewed
Oct 26, 2021
| REQUIRE(arg.get_type() == rttr::type::get<simple_type>()); | ||
|
|
||
|
|
||
| ///////////////////////////////////////////////////////////////////////////////////////// |
Author
There was a problem hiding this comment.
This UT has different behaviour on Clang than GCC (it passes if built with Clang but failed with GCC).
It could indicate that we were doing something wrong here (such as an undefined behaviour), but at this time we do not actually care about the behaviour when passing in a void* so I decided to remove it after a discussion with James.
Make rttr give bindr5000 a reasonable error if it fails to load a dll, a message like the one below is way more helpful than just silently failing: "rttr failed to load Cognex.OMX, Cannot load library Cognex.OMX /home/omxdev/build_e/bin/libCognex.OMX.so: undefined symbol: _ZNK17ccFrequencyBuffer5widthEv"
Add the compiler recognition for visual studio 2019.
When this #pragma is present, if you use /external:W0 for your project then all your internal headers are also set to /W0 for warning level.
LD_LIBRARY_PATH was not set correctlyqqq
Additional: disable initializer list warning
YangJiao1996
force-pushed
the
feature/rttr-webassembly-update
branch
from
fc40694 to
5a5efd9
Compare
Author
|
Closing this PR since this branch ended up in a terrible state of commit history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
void*error inget_reference_argumentto resolve errors/warnings reported by Clang/Emscripten.
This PR also rebases off the latest rttrorg/rttr/master commits.
For reviewers: most commits in this PR are from the rebase. Please focus on reviewing commit
0104c37tofc40694which are "real" contents of the PR.