Bugfix for periodic boundary conditions #102
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the following code throws an exception:
It looks like this happens because in
adaptiveTOCollocationStiffnessMatrix
there is an attempt to avoid unnecessary evaluations of the flow by only applying it to the firstnum_real_points
points. The actual redundant points however, may be distributed differently across the indices. Also, inadaptiveTOFutureGrid
, it is assumed thatflow_map_images
is populated with the images of every point, so this is where the error is thrown.This seems like the most direct fix. As the redundant points are typically on the boundary and thus very few, the effect on performance should be negligible.