Added support for ViewportTexture to Decals and projectors and update…#1
Draft
TheMagnat wants to merge 1 commit into
Draft
Added support for ViewportTexture to Decals and projectors and update…#1TheMagnat wants to merge 1 commit into
TheMagnat wants to merge 1 commit into
Conversation
… the texture in the DecalAtlas - Resolve Proxy textures in the update_decal_atlas method and decal_atlas_redraw_textures methods - decal_atlas_mark_draw_on_texture is now in the base class RendererTextureStorage - Removed ViewportTexture restriction in Decals and Light Projectors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the comment of godotengine#115653 (comment), I gave a try on adding ViewportTexture redraw support on decal atlas. This is a draft, I think my approach on resolving the proxy texture awkward and I would love to get some help and feedback on what I've done so far. I'm not sure if I'm doing correctly the "used" update.
A big issue from my implementation is that the Viewport texture get duplicated everytime a new ViewportTexture is added to it :
Done in this PR :
I also think maybe this should be done in a separate PR on the Godot repository, since your original PR already work well.
demoViewport.mp4