-
Notifications
You must be signed in to change notification settings - Fork 274
N°7289 - Read-only attribute, dynamically read-write, entry silently ignored on submission #724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
N°7289 - Read-only attribute, dynamically read-write, entry silently ignored on submission #724
Conversation
| * this is used to check the current value in GetAttributeFlag function (useful to manage dynamic readonly attributes) | ||
| * @param $sAttr | ||
| */ | ||
| public function GetCurrentValue($sAttCode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method name too vague and comment are somewhat cryptic to me.
Need some dialog to find how to name and describe things.
| * this is used to check if field has been modifed in GetAttributeFlag function (useful to manage dynamic readonly attributes) | ||
| * @param $sAttr | ||
| */ | ||
| public function IsModifiedValue($sAttCode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method name too vague and comment are somewhat cryptic to me.
Need some dialog to find how to name and describe things.
5ad63c5 to
d13532d
Compare
Co-authored-by: Thomas Casteleyn <[email protected]>
…essage only on console and portal context. Avoid messages during tests, setup and other case
456854d to
88c19e6
Compare
use this delta with GetCurrentValue in place of Get and Vincent's example (in bug 7289) will work :